Remove vendor docs (#534)
As title, we no longer use vendoring (or dep!). Also updated the link to Discord. Co-authored-by: jolheiser <john.olheiser@gmail.com> Reviewed-on: https://gitea.com/gitea/tea/pulls/534 Reviewed-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: John Olheiser <john+gitea@jolheiser.com> Co-committed-by: John Olheiser <john+gitea@jolheiser.com>
This commit is contained in:
parent
1a6d9b343a
commit
342b573d45
|
@ -7,7 +7,6 @@
|
||||||
- [Bug reports](#bug-reports)
|
- [Bug reports](#bug-reports)
|
||||||
- [Discuss your design](#discuss-your-design)
|
- [Discuss your design](#discuss-your-design)
|
||||||
- [Testing redux](#testing-redux)
|
- [Testing redux](#testing-redux)
|
||||||
- [Vendoring](#vendoring)
|
|
||||||
- [Code review](#code-review)
|
- [Code review](#code-review)
|
||||||
- [Styleguide](#styleguide)
|
- [Styleguide](#styleguide)
|
||||||
- [Sign-off your work](#sign-off-your-work)
|
- [Sign-off your work](#sign-off-your-work)
|
||||||
|
@ -60,20 +59,6 @@ high-level discussions.
|
||||||
Before sending code out for review, run all the test by executing: `make test`
|
Before sending code out for review, run all the test by executing: `make test`
|
||||||
Since TEA is an cli tool it should be obvious to test your feature locally first.
|
Since TEA is an cli tool it should be obvious to test your feature locally first.
|
||||||
|
|
||||||
## Vendoring
|
|
||||||
|
|
||||||
We keep a cached copy of dependencies within the `vendor/` directory,
|
|
||||||
managing updates via [dep](https://github.com/golang/dep).
|
|
||||||
|
|
||||||
Pull requests should only include `vendor/` updates if they are part of
|
|
||||||
the same change, be it a bugfix or a feature addition.
|
|
||||||
|
|
||||||
The `vendor/` update needs to be justified as part of the PR description,
|
|
||||||
and must be verified by the reviewers and/or merger to always reference
|
|
||||||
an existing upstream commit.
|
|
||||||
|
|
||||||
You can find more information on how to get started with it on the [dep project website](https://golang.github.io/dep/docs/introduction.html).
|
|
||||||
|
|
||||||
## Code review
|
## Code review
|
||||||
|
|
||||||
Changes to TEA must be reviewed before they are accepted—no matter who
|
Changes to TEA must be reviewed before they are accepted—no matter who
|
||||||
|
@ -175,7 +160,7 @@ maintainers](MAINTAINERS). Every PR **MUST** be reviewed by at least
|
||||||
two maintainers (or owners) before it can get merged. A maintainer
|
two maintainers (or owners) before it can get merged. A maintainer
|
||||||
should be a contributor of Gitea (or Gogs) and contributed at least
|
should be a contributor of Gitea (or Gogs) and contributed at least
|
||||||
4 accepted PRs. A contributor should apply as a maintainer in the
|
4 accepted PRs. A contributor should apply as a maintainer in the
|
||||||
[Discord](https://discord.gg/NsatcWJ) #develop channel. The owners
|
[Discord](https://discord.gg/Gitea) #develop channel. The owners
|
||||||
or the team maintainers may invite the contributor. A maintainer
|
or the team maintainers may invite the contributor. A maintainer
|
||||||
should spend some time on code reviews. If a maintainer has no
|
should spend some time on code reviews. If a maintainer has no
|
||||||
time to do that, they should apply to leave the maintainers team
|
time to do that, they should apply to leave the maintainers team
|
||||||
|
@ -208,7 +193,7 @@ https://help.github.com/articles/securing-your-account-with-two-factor-authentic
|
||||||
|
|
||||||
After the election, the new owners should proactively agree
|
After the election, the new owners should proactively agree
|
||||||
with our [CONTRIBUTING](CONTRIBUTING.md) requirements in the
|
with our [CONTRIBUTING](CONTRIBUTING.md) requirements in the
|
||||||
[Discord](https://discord.gg/NsatcWJ) #general channel. Below are the
|
[Discord](https://discord.gg/Gitea) #general channel. Below are the
|
||||||
words to speak:
|
words to speak:
|
||||||
|
|
||||||
```
|
```
|
||||||
|
|
|
@ -117,7 +117,6 @@ Fork -> Patch -> Push -> Pull Request
|
||||||
|
|
||||||
- `make test` run testsuite
|
- `make test` run testsuite
|
||||||
- `make vet` run checks (check the order of imports; preventing failure on CI pipeline beforehand)
|
- `make vet` run checks (check the order of imports; preventing failure on CI pipeline beforehand)
|
||||||
- `make vendor` when adding new dependencies
|
|
||||||
- ... (for other development tasks, check the `Makefile`)
|
- ... (for other development tasks, check the `Makefile`)
|
||||||
|
|
||||||
**Please** read the [CONTRIBUTING](CONTRIBUTING.md) documentation, it will tell you about internal structures and concepts.
|
**Please** read the [CONTRIBUTING](CONTRIBUTING.md) documentation, it will tell you about internal structures and concepts.
|
||||||
|
|
Loading…
Reference in New Issue