From c42c7ca97c02119bee9555c374b1ddea61a2d514 Mon Sep 17 00:00:00 2001 From: formsdev <136701234+formsdev@users.noreply.github.com> Date: Wed, 16 Aug 2023 14:20:51 +0530 Subject: [PATCH] Validation logic bug, required with logic hidden (#164) --- app/Service/Forms/FormLogicPropertyResolver.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Service/Forms/FormLogicPropertyResolver.php b/app/Service/Forms/FormLogicPropertyResolver.php index 6e3f6f8..b57c4ff 100644 --- a/app/Service/Forms/FormLogicPropertyResolver.php +++ b/app/Service/Forms/FormLogicPropertyResolver.php @@ -39,7 +39,7 @@ class FormLogicPropertyResolver } $conditionsMet = FormLogicConditionChecker::conditionsMet($this->logic['conditions'], $this->formData); - if ($conditionsMet && $this->property['required'] && count($this->logic['actions']) > 0 && in_array('make-it-optional', $this->logic['actions'])) { + if ($conditionsMet && $this->property['required'] && count($this->logic['actions']) > 0 && (in_array('make-it-optional', $this->logic['actions']) || in_array('hide-block', $this->logic['actions']))) { return false; } else if ($conditionsMet && !$this->property['required'] && count($this->logic['actions']) > 0 && in_array('require-answer', $this->logic['actions'])) { return true;